Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove babel from eslint config #2788

Closed

Conversation

koddsson
Copy link
Member

What I did

  1. I removed the babel parser dependency as I don't think that's needed any more.

Copy link

changeset-bot bot commented Apr 10, 2024

🦋 Changeset detected

Latest commit: e2e2c55

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@open-wc/eslint-config Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@koddsson koddsson requested a review from thepassle April 10, 2024 07:07
@koddsson koddsson marked this pull request as draft April 10, 2024 08:43
@koddsson
Copy link
Member Author

Looks like espree doesn't actually support import types so I'm not sure why I was seeing that in my tests. Probably my config is importing a different parser from somewhere else?

@koddsson
Copy link
Member Author

I don't get why eslint isn't crashing in my app but everything seems to indicate that espree doesn't support import attributes so 🤷🏻

@koddsson koddsson closed this Apr 10, 2024
@koddsson koddsson deleted the remove-babel-from-eslint-config branch April 10, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant