Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow lit 3 #2723

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Allow lit 3 #2723

wants to merge 8 commits into from

Conversation

alexgagnon
Copy link

What I did

  1. Update peerDependencies to include Lit@3
  2. Fix issue in packages/codelabs/src/intermediate/lit-html.md that was causing failures in prettier
  3. Fix issue in `packages/dev-server-hmr/src/hmrPlugin.js that was causing failures in tsc
  4. Provide files for testing against both Lit@2 and Lit@3

@changeset-bot
Copy link

changeset-bot bot commented Oct 25, 2023

🦋 Changeset detected

Latest commit: 556444f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@open-wc/lit-helpers Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


alexgagnon seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@@ -36,5 +37,9 @@
"peerDependencies": {
"lit": "^2.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we actually need to vend multiple exports/add multiple hard dependencies, or can we just loosen this peerDependency to include ^2.0.0 || ^3.0.0 so that the consuming project can continue to outline the versions of the dependencies they need rather than forcing both versions that the change does now?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sigh I switched laptops and forgot to put the only change that was actually needed... new commit updates the "peerDependencies", and I updated "dependencies" to "devDependencies"

@JosefJezek
Copy link

JosefJezek commented Nov 23, 2023

any progress? Why do you create the spread for lit 2, file spread-lit2.js?

@Westbrook
Copy link
Contributor

This should have been fast forwarded as part of other changes. Can you check the latest versions?

@raphaelokon
Copy link

@Westbrook Do you need help on this topic? It is blocking us from updating to lit@3 …

@alexgagnon
Copy link
Author

alexgagnon commented Dec 8, 2023

any progress? Why do you create the spread for lit 2, file spread-lit2.js?

spread-2.ts references lit@2 while spread.ts is updated for lit@3 so that both major versions can be tested.

I doesn't look like this has made it into upstream yet, and this is getting out of date. I'll close this and open another one with most recent changes

@Westbrook before I do... any issue with the current PR you'd want to see different? Is the testing against both Lit 2 and 3 the approach you want?

@tirithen
Copy link

tirithen commented Apr 8, 2024

What is holding up this pull request? Anything that can be done to speed it up a bit and merge? @Westbrook @alexgagnon

Can the scope of this pull request be reduced somehow to get build pipelines working for projects that want to upgrade to lit 3?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants