Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing exports entry to dedupe-mixin package.json #2496

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mservaising
Copy link

@mservaising mservaising commented Oct 17, 2022

What I did

Fixes #2495

  1. I added the export in the package.json of dedup-mixin package.

@changeset-bot
Copy link

changeset-bot bot commented Oct 17, 2022

🦋 Changeset detected

Latest commit: 523b96b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@open-wc/dedupe-mixin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Oct 17, 2022

CLA assistant check
All committers have signed the CLA.

@thepassle
Copy link
Member

this is a breaking change

@mservaising
Copy link
Author

ok, just to understand, why it is a breaking change ?

@thepassle
Copy link
Member

Adding a package exports map is usually (if not always) a breaking change. In this case it will only allow imports like import { foo } from '@open-wc/dedupe-mixin'. So if anybody imports it differently, for example import { foo } from '@open-wc/dedupe-mixin/index.js', that will now no longer work

@mservaising
Copy link
Author

then have you any other fix for the issue I got above (using ing-web 3) but I suppose it is the same with lion

@web-padawan web-padawan changed the title fix: #2495 no export in package.json (fixing DeprecationWarning DEP0151) fix: add missing exports entry to dedupe-mixin package.json Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dedupe-mixin has DeprecationWarning No "main" or "exports" field
4 participants