-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add k8s.container.status.current_waiting_reason resource attribute #997
Conversation
0d95649
to
f756629
Compare
f756629
to
73469b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Would appreciate a review here 🙇 Maybe @TylerHelmuth or @lmolkova you could take a look 👀 |
@open-telemetry/semconv-k8s-approvers @open-telemetry/specs-semconv-approvers please take a look. |
sorry for the late comment, was just curious if there was any discussion already about this resource attribute being non-immutable? |
@trask The collector linked PR says:
But I see that this is not reflected in the attribute definition and can be confusing. @povilasv can you please clarify if this is the correct assumption of this attribute? Resource attributes are immutable. Is it even possible to know the "last terminated reason"? Or are we assuming to take the current state and that's it? |
#968 introduced the |
Yeah, probably as events I'd say. |
Hey folks, Did not know about immutability constraint on resource attributes. Sorry for this. Looks like But I think it would be best to model it as metric that tracks state changes. Also events are an option. I guess we also should remove these two and model it differently. How do I revert PRs/ deprecate the attributes? |
We don't allow removing things anymore and just deprecating, but since this wasn't released yet I think we can just remove it. What do you think @lmolkova ? The other one that was merged |
I don't think |
While that's most probably true, I wonder if we should find a consistent way to model both of them. It could be weird to find |
Agree |
it's ok to remove things that haven't been released - we know that nothing depends on it. |
Fixes #996
Changes
Please provide a brief description of the changes here.
Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.
Merge requirement checklist
[chore]