-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend GenAI system well-known values #1020
Open
TaoChenOSU
wants to merge
5
commits into
open-telemetry:main
Choose a base branch
from
TaoChenOSU:extend-gen-ai-system-values
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Extend GenAI system well-known values #1020
TaoChenOSU
wants to merge
5
commits into
open-telemetry:main
from
TaoChenOSU:extend-gen-ai-system-values
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirga
reviewed
May 9, 2024
lmolkova
reviewed
May 9, 2024
lmolkova
reviewed
May 9, 2024
lmolkova
reviewed
May 9, 2024
I think HuggingFace will be the most controversial one. It's neither a model provider nor a service provider. You can use its inference endpoint but for production people may use their dedicated endpoints, which can be hosted on Azure, AWS or GCP. |
I removed some of the most controversial values. The remaining ones are known to have client SDKs. |
lmolkova
reviewed
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more well-known GenAI model providers to the list of possible values that the
gen_ai.system
attribute can take.Changes
The following are added:
microsoft
huggingface
google
meta
anthropic
mistral
cohere
Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.
Merge requirement checklist
[chore]