Log Data Model: Rename ShortName to Name #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributes to open-telemetry/opentelemetry-specification#622 This aligns the naming to what is already used for Embedded Logs (Span.Event). There is no change of semantics.
tigrannajaryan
requested review from
arminru,
bogdandrutu,
c24t,
carlosalberto,
iredelmeier,
jmacd,
reyang,
SergeyKanzhelev,
tedsuo and
yurishkuro
as code owners
MikeGoldsmith
approved these changes
May 28, 2020
reyang
approved these changes
May 29, 2020
thedrow
approved these changes
May 29, 2020
arminru
approved these changes
May 29, 2020
rahulchheda
approved these changes
May 30, 2020
zenmoto
approved these changes
Jun 2, 2020
bogdandrutu
approved these changes
Jun 3, 2020
carlosalberto
approved these changes
Jun 3, 2020
|
Thanks for the approvals. Maintainers: please merge the PR. |
|
Thanks @carlosalberto ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to open-telemetry/opentelemetry-specification#622
This aligns the naming to what is already used for Embedded Logs (Span.Event).
There is no change of semantics.