Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update accountingservice #4448

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

RassK
Copy link

@RassK RassK commented May 8, 2024

Why

related to open-telemetry/opentelemetry-demo#1538

What

Updates accounting service documentation according to the demo PR.

@RassK RassK force-pushed the update-accountingservice branch 2 times, most recently from 8cb2def to 2d80588 Compare May 8, 2024 13:04
@svrnm svrnm marked this pull request as ready for review May 10, 2024 08:33
@svrnm svrnm requested review from a team as code owners May 10, 2024 08:33
Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, I mark it as "blocked" since it depends on the upstream PR to be merged

cc @open-telemetry/demo-approvers

@svrnm svrnm added the blocked label May 10, 2024
@svrnm svrnm changed the title [Draft] Update accountingservice Update accountingservice May 13, 2024
@svrnm
Copy link
Member

svrnm commented May 13, 2024

/fix:all

@opentelemetrybot
Copy link
Contributor

You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/9058732086

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants