New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move java sdk configuration documentation into docs site #4377
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! First pass review follows.
@open-telemetry/java-instrumentation-maintainers PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor drive-by comment regarding use of a "real" (bidirectionally linked) footnote.
@chalin I looked around for a pattern to follow for footnotes to ensure consistency and landed on mirroring the |
@open-telemetry/java-approvers @open-telemetry/java-instrumentation-approvers PTAL! |
Hi @jaydeluca - I've edited the opening comment to indicate that this PR contributes to #4032. We should only close #4032 once the corresponding pieces are removed from that file (I don't know if the entire file is covered here and will therefore be removed, or have a link added to this page). WDYT? |
Contributes to:
java/automatic/configuration
links out to pages that should be moved to docs #4032A few notes:
Preview: https://deploy-preview-4377--opentelemetry.netlify.app/docs/languages/java/automatic/configuration/#resources