Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links in Nomad post and JS pages #2355

Merged

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Feb 16, 2023

  • Contributes to CI: check external links #1052
  • External link checking highlighted some broken links.
    • @avillela: please review the Nomad blog post updates. (Note: I ran Prettier over the file too.)
    • @open-telemetry/javascript-approvers: please review the link updates to the JS pages

Previews:

@chalin chalin requested review from a team as code owners February 16, 2023 23:13
- [Context API reference](https://open-telemetry.github.io/opentelemetry-js-api/classes/contextapi.html)
- [Context API reference](https://open-telemetry.github.io/opentelemetry-js/classes/_opentelemetry_api.ContextAPI.html)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@open-telemetry/javascript-approvers is this a valid updated link? If not, what should it be?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we don't hear back soon-ish then I'd so let's go with this, it's correct insofar as I'm not aware of any other context API reference

@chalin chalin requested a review from avillela February 17, 2023 00:40
@chalin
Copy link
Contributor Author

chalin commented Feb 17, 2023

@cartermp - do you think that you could review the blog post in case @avillela isn't available? Thanks!

@cartermp
Copy link
Contributor

The post looks good to me.

@cartermp cartermp merged commit 57944c8 into open-telemetry:main Feb 17, 2023
@chalin chalin deleted the chalin-im-fix-external-links-2023-02-16 branch February 17, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants