Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Knative blog copyedits #1473

Merged
merged 2 commits into from Jun 22, 2022
Merged

Knative blog copyedits #1473

merged 2 commits into from Jun 22, 2022

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Jun 22, 2022 •
edited

  • Normalize links, in particular to the local spec pages (contributes to Intra-site links should not be external #922)
  • Run markdown prettifier
  • Fix typos in image title
  • Changed code-block language to nocode in two cases
  • No other changes were made to the prose

/cc @pavolloffay

@chalin chalin requested review from a team as code owners June 22, 2022 14:45
@chalin chalin mentioned this pull request Jun 22, 2022
Closed
18 tasks
@chalin
Copy link
Contributor Author

chalin commented Jun 22, 2022

Oh, I did add a linkTitle - PTAL.

@pavolloffay - since this is mainly a "cleanup" PR, I'll merge now. I can address any comments you have in a followup PR.

chalin
chalin commented Jun 22, 2022
View reviewed changes
content/en/blog/2022/knative.md
@@ -1,53 +1,112 @@
---
title: Distributed tracing in Knative
linkTitle: Tracing in Knative
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pavolloffay - notice the shortened title, which appears in the blog left-nav. Hopefully you're ok with this.

@chalin chalin merged commit 445043c into open-telemetry:main Jun 22, 2022
@chalin chalin deleted the chalin-im-knative-blog-2022-06-22 branch June 22, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cleanup/refactoring copyedit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@chalin