Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[editorial] Inline Hugo front matter #4046

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chalin
Copy link
Contributor

@chalin chalin commented May 10, 2024

/cc @reyang @carlosalberto @svrnm

@chalin chalin requested review from a team as code owners May 10, 2024 21:28
@chalin
Copy link
Contributor Author

chalin commented May 10, 2024

I'm looking into the markdown-toc GH action failure.

@chalin
Copy link
Contributor Author

chalin commented May 10, 2024

Hmm, the markdown-toc tool seems to be cleaning up more than just the TOC. It strips the comment from the front matter and removes any blank lines between the title and the front matter 🤷🏼‍♂️. I'll commit the change so that you can see.

Yes, I confirm that it's a known issue:

@chalin
Copy link
Contributor Author

chalin commented May 10, 2024

So strange, markdown-toc is also adding blank lines at the end of files!

@chalin
Copy link
Contributor Author

chalin commented May 10, 2024

Ok, well ... due to unresolved bugs in markdown-toc, we can't inline Hugo front matter 🤷🏼‍♂️
Ref.: jonschlinkert/markdown-toc#151 (comment).

@chalin chalin force-pushed the chalin-im-hugo-front-matter-2024-05-10 branch from 676cb98 to 2ae284b Compare May 10, 2024 21:54
@chalin
Copy link
Contributor Author

chalin commented May 10, 2024

I've removed the commits that contained the markdown-toc mangled content. So there should be only one GH action failure, the markdown-toc check.

So, it seems that this can't be merged until markdown-toc is fixed. :-/

@chalin
Copy link
Contributor Author

chalin commented May 10, 2024

I could modify the markdown-toc make rule to temporarily comment out the front matter, but I'm not sure that it's worth it. WDYT @reyang et all?

@jsuereth
Copy link
Contributor

Approved pending TOC fix.

@chalin
Copy link
Contributor Author

chalin commented May 15, 2024

Ok, I'll tackle on the markdown-toc workaround as soon as I can.

Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label May 23, 2024
@chalin
Copy link
Contributor Author

chalin commented May 28, 2024

Nope, not stale, I was OOO.

@arminru arminru removed the Stale label May 28, 2024
@carlosalberto carlosalberto reopened this Jun 4, 2024
@chalin
Copy link
Contributor Author

chalin commented Jun 4, 2024

Heads up that I'm really swamped atm, so I'm unsure when I'll be able to get to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Editorial] Inline Hugo front matter
7 participants