Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[configuration] Add example using hexadecimal notation #3975

Merged
merged 5 commits into from
May 8, 2024

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Apr 2, 2024

Updates #3959

Changes

Adds example for using an integer in hexadecimal notation. The intention is to show the difference when quoting vs not quoting and make explicit that quoting means keeping the original representation (we already have the true example but this one has two different representations).

I think this is already implied by the text so this is only a change in the example.

@mx-psi mx-psi requested review from a team as code owners April 2, 2024 16:20
@mx-psi
Copy link
Member Author

mx-psi commented Apr 2, 2024

cc @open-telemetry/configuration-maintainers

@mx-psi
Copy link
Member Author

mx-psi commented Apr 2, 2024

Also cc @evan-bradley @astencel-sumo @swiatekm-sumo since we discussed something related at Kubecon, in case you want to take a look :)

Co-authored-by: Robert Pająk <pellared@hotmail.com>
@mx-psi
Copy link
Member Author

mx-psi commented Apr 9, 2024

Since the behavior here depends on supporting the core schema I am going to mark this as draft until we decide on #3973

@mx-psi mx-psi marked this pull request as draft April 9, 2024 11:43
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Apr 17, 2024
Copy link

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Apr 25, 2024
@mx-psi
Copy link
Member Author

mx-psi commented Apr 25, 2024

Will ask for this to be reopened once we resolve #3973

@mx-psi
Copy link
Member Author

mx-psi commented May 8, 2024

@jack-berg would you be able to reopen this? I don't have permissions and want to retake this after #3973 has been merged

@jack-berg jack-berg reopened this May 8, 2024
@mx-psi mx-psi marked this pull request as ready for review May 8, 2024 12:19
@mx-psi
Copy link
Member Author

mx-psi commented May 8, 2024

This just exemplifies what should happen now that we have #3973: 0xdeadbeef SHOULD be parsed as a number if unquoted, and as a string if quoted (given that environment variable resolution happens before YAML parsing)

Copy link
Member

@jack-berg jack-berg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me. I updated the java implementation to reflect this: open-telemetry/opentelemetry-java#6436

@jack-berg jack-berg merged commit 0d7363d into open-telemetry:main May 8, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants