Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark base-2 exponential histogram as stable #3041

Merged
merged 11 commits into from
Jan 13, 2023
Merged

Mark base-2 exponential histogram as stable #3041

merged 11 commits into from
Jan 13, 2023

Conversation

jack-berg
Copy link
Member

Resolves #2832.

@jack-berg jack-berg requested review from a team as code owners December 15, 2022 19:29
@pirgeo
Copy link
Member

pirgeo commented Dec 19, 2022

Is this pending on #3017?

@arminru arminru added spec:metrics Related to the specification/metrics directory area:data-model For issues related to data model labels Dec 19, 2022
@jack-berg
Copy link
Member Author

I think #3017 is nice to have, but not blocking since its a backwards compatible addition.

@carlosalberto
Copy link
Contributor

Circling back on Jack's last question: should the expo aggregation be a SHOULD or a MUST for each language?

cc @jsuereth @jmacd @reyang

@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Dec 30, 2022
@jsuereth
Copy link
Contributor

I'm ok with SHOULD or MUST. For SDKs that need help implementing exponential histogram, happy to pitch in.

@jack-berg
Copy link
Member Author

I've changed the aggregation name to "Base2 Exponential Bucket Histogram Aggregation" per this conversation.

Note that the metric point defined in data-model.md is still named ExponentialHistogram, since the same point could be reused with a base 10 exponential histogram aggregation.

MrAlias
MrAlias reviewed Jan 12, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@reyang reyang merged commit 66c655b into open-telemetry:main Jan 13, 2023
@reyang reyang changed the title Mark exponential histogram as stable Mark base-2 exponential histogram as stable Jan 13, 2023
@reyang reyang mentioned this pull request Jan 13, 2023
Merged
@jack-berg jack-berg mentioned this pull request Jan 13, 2023
Merged
@jack-berg jack-berg mentioned this pull request Jan 21, 2023
Merged
@lenin-jaganathan lenin-jaganathan mentioned this pull request May 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmacd jmacd jmacd approved these changes

@MrAlias MrAlias MrAlias left review comments

@reyang reyang reyang approved these changes

@pirgeo pirgeo pirgeo left review comments

@jsuereth jsuereth jsuereth approved these changes

@carlosalberto carlosalberto carlosalberto approved these changes

Assignees

@carlosalberto carlosalberto

Labels
area:data-model For issues related to data model spec:metrics Related to the specification/metrics directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stabilize exponential histograms
8 participants
@jack-berg @pirgeo @carlosalberto @jsuereth @jmacd @MrAlias @reyang @arminru