add schema definition for direction change #2688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Leaving this as a draft as schema check will fail until open-telemetry/build-tools#106 is resolved |
This is a follow up to open-telemetry#2617 now that open-telemetry#2653 has been merged.
codeboten
force-pushed
the
codeboten/add-schema-direction
branch
from
64e3d37
to
b14f50d
Compare
tigrannajaryan
approved these changes
Jul 27, 2022
jmacd
approved these changes
Jul 27, 2022
tigrannajaryan
added a commit
to tigrannajaryan/opentelemetry-specification
that referenced
this pull request
Aug 23, 2022
…ry#2617)" Contributes to open-telemetry#2726 This reverts open-telemetry#2617 We are reverting open-telemetry#2617 until we are certain how to resolve issue open-telemetry#2726 Also reverts the corresponding schema file changes done in open-telemetry#2688
tigrannajaryan
added a commit
to tigrannajaryan/opentelemetry-specification
that referenced
this pull request
Aug 29, 2022
…ry#2617)" Contributes to open-telemetry#2726 This reverts open-telemetry#2617 We are reverting open-telemetry#2617 until we are certain how to resolve issue open-telemetry#2726 Also reverts the corresponding schema file changes done in open-telemetry#2688
tigrannajaryan
added a commit
to tigrannajaryan/opentelemetry-specification
that referenced
this pull request
Aug 30, 2022
…ry#2617)" Contributes to open-telemetry#2726 This reverts open-telemetry#2617 We are reverting open-telemetry#2617 until we are certain how to resolve issue open-telemetry#2726 Also reverts the corresponding schema file changes done in open-telemetry#2688
tigrannajaryan
added a commit
that referenced
this pull request
Sep 2, 2022
…ection`" (#2748) Please review this carefully. It is not an automatic reverting, I had to fix merge conflicts manually and may have made mistakes, so a thorough review is needed. Changes: - This reverts #2617. We are reverting it until we are certain how to resolve issue #2726 - Also reverts the corresponding schema file changes done in #2688 - Also reverts #2675 ~Note that this does not revert #2675 which I believe to still be valid. If you think otherwise please speak.~ [UPDATE: discussed in Spec SIG and decided to revert 2675 too]. Contributes to #2726
MSNev
pushed a commit
to MSNev/opentelemetry-specification
that referenced
this pull request
Sep 6, 2022
… "add metrics to replace metrics with `direction`" (open-telemetry#2748) Please review this carefully. It is not an automatic reverting, I had to fix merge conflicts manually and may have made mistakes, so a thorough review is needed. Changes: - This reverts open-telemetry#2617. We are reverting it until we are certain how to resolve issue open-telemetry#2726 - Also reverts the corresponding schema file changes done in open-telemetry#2688 - Also reverts open-telemetry#2675 ~Note that this does not revert open-telemetry#2675 which I believe to still be valid. If you think otherwise please speak.~ [UPDATE: discussed in Spec SIG and decided to revert 2675 too]. Contributes to open-telemetry#2726
ChengJinbao
added a commit
to ChengJinbao/opentelemetry-specification
that referenced
this pull request
Nov 16, 2022
…ection`" (#2748) Please review this carefully. It is not an automatic reverting, I had to fix merge conflicts manually and may have made mistakes, so a thorough review is needed. Changes: - This reverts open-telemetry/opentelemetry-specification#2617. We are reverting it until we are certain how to resolve issue #2726 - Also reverts the corresponding schema file changes done in open-telemetry/opentelemetry-specification#2688 - Also reverts open-telemetry/opentelemetry-specification#2675 ~Note that this does not revert open-telemetry/opentelemetry-specification#2675 which I believe to still be valid. If you think otherwise please speak.~ [UPDATE: discussed in Spec SIG and decided to revert 2675 too]. Contributes to open-telemetry/opentelemetry-specification#2726
jsuereth
pushed a commit
to jsuereth/otel-semconv-test
that referenced
this pull request
Apr 19, 2023
…ection`" (#2748) Please review this carefully. It is not an automatic reverting, I had to fix merge conflicts manually and may have made mistakes, so a thorough review is needed. Changes: - This reverts open-telemetry/opentelemetry-specification#2617. We are reverting it until we are certain how to resolve issue #2726 - Also reverts the corresponding schema file changes done in open-telemetry/opentelemetry-specification#2688 - Also reverts open-telemetry/opentelemetry-specification#2675 ~Note that this does not revert open-telemetry/opentelemetry-specification#2675 which I believe to still be valid. If you think otherwise please speak.~ [UPDATE: discussed in Spec SIG and decided to revert 2675 too]. Contributes to open-telemetry/opentelemetry-specification#2726
jsuereth
pushed a commit
to open-telemetry/semantic-conventions
that referenced
this pull request
May 11, 2023
…ection`" (#2748) Please review this carefully. It is not an automatic reverting, I had to fix merge conflicts manually and may have made mistakes, so a thorough review is needed. Changes: - This reverts open-telemetry/opentelemetry-specification#2617. We are reverting it until we are certain how to resolve issue #2726 - Also reverts the corresponding schema file changes done in open-telemetry/opentelemetry-specification#2688 - Also reverts open-telemetry/opentelemetry-specification#2675 ~Note that this does not revert open-telemetry/opentelemetry-specification#2675 which I believe to still be valid. If you think otherwise please speak.~ [UPDATE: discussed in Spec SIG and decided to revert 2675 too]. Contributes to open-telemetry/opentelemetry-specification#2726
joaopgrassi
pushed a commit
to dynatrace-oss-contrib/semantic-conventions
that referenced
this pull request
Mar 21, 2024
…ection`" (#2748) Please review this carefully. It is not an automatic reverting, I had to fix merge conflicts manually and may have made mistakes, so a thorough review is needed. Changes: - This reverts open-telemetry/opentelemetry-specification#2617. We are reverting it until we are certain how to resolve issue #2726 - Also reverts the corresponding schema file changes done in open-telemetry/opentelemetry-specification#2688 - Also reverts open-telemetry/opentelemetry-specification#2675 ~Note that this does not revert open-telemetry/opentelemetry-specification#2675 which I believe to still be valid. If you think otherwise please speak.~ [UPDATE: discussed in Spec SIG and decided to revert 2675 too]. Contributes to open-telemetry/opentelemetry-specification#2726
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This is a follow up to #2617 now that #2653 has been merged.
Related issues #2589