Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce "split" metric schema transformation #2653

Merged
merged 3 commits into from Jul 21, 2022
Merged

Introduce "split" metric schema transformation #2653

merged 3 commits into from Jul 21, 2022

Commits on Jul 20, 2022

  1. Introduce "split" metric schema transformation 

    This is a new transformation type that allows to describe a change
where a metric is converted to several other metrics by eliminating
an attribute.

An example of such change that happened recently is this:
open-telemetry#2617

This PR contains:
- A new "split" transformation added to the schema file format.
- Schema file format incremented from 1.0.0 to 1.1.0. This is considered
  a backward compatible change and thus the minor version number is
  incremented.
- Deleted incorrect sentence that claimed that the addition of a new
  transformation type is not backward compatible and requires a
  major version number change. This is incorrect. Addition of
  new transformation types is backward compatible according to our
  current definition of backward compatibility, which is:
  "consumers can consume version X.Y and older versions X.Z
  provided that they are aware of version X.Y".
- Deleted the requirement that a full OTEP is always necessary to
  introduce new transformation types. This seems excessive. I think
  in simple cases like this a PR directly in the spec is sufficient.

This draft PR shows how the corresponding implementation of schema file
parser in Go can be done:
open-telemetry/opentelemetry-go#2999

This commit in my personal repo shows in more detail how the "split"
transformation can be implemented:
tigrannajaryan/telemetry-schema@2b45e48
    @tigrannajaryan
    tigrannajaryan committed Jul 20, 2022
    Copy the full SHA
    da74575 View commit details
    Browse the repository at this point in the history

  2. Rename attributes_to_metrics to metrics_from_attributes

    @tigrannajaryan
    tigrannajaryan committed Jul 20, 2022
    Copy the full SHA
    a3a2d2b View commit details
    Browse the repository at this point in the history

  3. Rename attributes_to_metrics to metrics_from_attributes

    @tigrannajaryan
    tigrannajaryan committed Jul 20, 2022
    Copy the full SHA
    f24d2af View commit details
    Browse the repository at this point in the history