Loosen requirement for a major version bump #2510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cijothomas
reviewed
Apr 25, 2022
|
@open-telemetry/python-maintainers @open-telemetry/go-maintainers |
tigrannajaryan
approved these changes
Apr 26, 2022
bogdandrutu
approved these changes
Apr 26, 2022
cijothomas
approved these changes
Apr 26, 2022
alanwest
approved these changes
Apr 26, 2022
rauno56
approved these changes
Apr 26, 2022
There was a problem hiding this comment.
Even though it's a common practice to increment major versions of a package when even an EOL verision of the runtime is dropped in JS, I don't think it makes sense for API and probably SDK.
Bumping in that case would hurt interoperability and adoption immensely long term.
reyang
approved these changes
Apr 27, 2022
This was referenced Apr 27, 2022
ocelotl
approved these changes
Apr 27, 2022
yurishkuro
reviewed
Apr 28, 2022
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think a change in support for a language/runtime version should not necessarily force a major version bump.
Examples where I agree that making a version bump would be an overkill:
However, bumping a minor version in such cases makes sense.
PS. Maybe I wrongly understand what "a drop in support" means.
FYI @open-telemetry/dotnet-maintainers