Require a shorter test for the (optional) consistent probability sampler #2319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosalberto
approved these changes
Feb 7, 2022
bogdandrutu
approved these changes
Feb 8, 2022
|
@jmacd Lint is failing. |
…lemetry-specification into jmacd/less_prob_sample_test
|
Merging as this is a simplification (and overall a trivial change). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The Consistent Probability Sampler tests specified in #2047 require too much runtime in the OTel-Go repository to be acceptable. The test had specified trials using 1,000,000 spans. I've changed the specification to test 100,000 spans. Because we can't test very low probabilities with a smaller test, I've removed 5 of the 20 test cases, leaving 15 tests.
The OTel-Go tests run in under 1 minute (before recent span optimizations in that repo).
See open-telemetry/opentelemetry-go-contrib#1379