Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define span structure for HTTP retries and redirects #2078

Merged
merged 23 commits into from
Mar 9, 2022
Merged

Define span structure for HTTP retries and redirects #2078

merged 23 commits into from
Mar 9, 2022

Conversation

denisivan0v
Copy link
Contributor

@denisivan0v denisivan0v commented Oct 28, 2021 •
edited

Changes

This PR clarifies semantic conventions for HTTP retries and redirects and defines a span structure and linking as well as span attributes for retries. Changes were discussed recently at Instrumentation SIG meetings.

This change addresses a scenario which is in the scope for bringing the existing HTTP semantic conventions for tracing to an initial stable state, see related otep #174.

@denisivan0v denisivan0v requested review from a team as code owners October 28, 2021 20:47
@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Nov 10, 2021
@github-actions
Copy link

github-actions bot commented Dec 7, 2021

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Dec 7, 2021
@denisivan0v
Copy link
Contributor Author

Do folks know how to reopen this PR? Don't see the reopen button.

@yurishkuro yurishkuro reopened this Dec 7, 2021
@github-actions github-actions bot removed the Stale label Dec 8, 2021
@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Dec 15, 2021
@denisivan0v denisivan0v mentioned this pull request Dec 21, 2021
Closed
3 tasks
@denisivan0v
Copy link
Contributor Author

The implementation of changes proposed in this PR for .NET is done within the PR here opentelemetry-dotnet #2756.

@github-actions github-actions bot removed the Stale label Dec 21, 2021
@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@denisivan0v
Copy link
Contributor Author

@tedsuo, @jmacd I've made some significant changes to the text in order to address the feedback and make it more straightforward, however, in essence the proposal stays pretty much the same. Can you please have another look?

anuraaga
anuraaga approved these changes Feb 2, 2022
View reviewed changes
specification/trace/semantic_conventions/http.md Outdated Show resolved Hide resolved
specification/trace/semantic_conventions/http.md Outdated Show resolved Hide resolved
denisivan0v and others added 2 commits February 2, 2022 01:56
@denisivan0v @anuraaga
Update specification/trace/semantic_conventions/http.md
6126bed 
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
@denisivan0v
Typo
bb2c4e0
@github-actions github-actions bot removed the Stale label Feb 2, 2022
jamesmoessis
jamesmoessis approved these changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@jamesmoessis jamesmoessis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@denisivan0v denisivan0v mentioned this pull request Mar 2, 2022
Closed
@denisivan0v
Copy link
Contributor Author

@tigrannajaryan can you please help merging this PR?

@tigrannajaryan
Copy link
Member

This needs to wait for the 2 days cool-down period since the last change.

@bogdandrutu
Copy link
Member

Merging this as the initial step for this work.

@bogdandrutu
Copy link
Member

@denisivan0v I swear I tried, but @cijothomas commented before I was able to press the button, and we configured to have all conversations resolved. Please resolve them and I will merge after. you can ping me on slack when everything is resolved.

@tigrannajaryan tigrannajaryan merged commit 5fdeed8 into open-telemetry:main Mar 9, 2022
denisivan0v added a commit to denisivan0v/opentelemetry-dotnet that referenced this pull request Mar 22, 2022
@denisivan0v
Excluding span links based on decisions made in open-telemetry/opente…
00b6a84 
…lemetry-specification#2078
@denisivan0v denisivan0v mentioned this pull request Mar 23, 2022
Closed
@lmolkova lmolkova mentioned this pull request Apr 6, 2022
Merged
@denisivan0v denisivan0v mentioned this pull request Apr 19, 2022
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tedsuo tedsuo tedsuo approved these changes

@kenfinnigan kenfinnigan kenfinnigan left review comments

@yurishkuro yurishkuro yurishkuro left review comments

@cijothomas cijothomas cijothomas left review comments

@MSNev MSNev MSNev approved these changes

@anuraaga anuraaga anuraaga approved these changes

@bogdandrutu bogdandrutu bogdandrutu approved these changes

@jmacd jmacd jmacd approved these changes

@lzchen lzchen lzchen approved these changes

@jamesmoessis jamesmoessis jamesmoessis approved these changes

Assignees

@tigrannajaryan tigrannajaryan

Labels
None yet
Projects
No open projects
Spec: HTTP
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet