Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update env vars in spec compliance matrix #1827

Merged
merged 2 commits into from Jul 28, 2021

Conversation

pellared
Copy link
Member

@pellared pellared commented Jul 26, 2021

@carlosalberto
Copy link
Contributor

@open-telemetry/dotnet-maintainers We need at least one approval from you ;)

|OTEL_LOG_LEVEL | - | - | + | [-][py1059] | + | + | - | | - | - | - |
|OTEL_PROPAGATORS | - | + | | + | + | + | - | - | - | - | - |
|OTEL_BSP_* | - | + | | + | + | + | - | + | - | - | - |
|OTEL_EXPORTER_OTLP_* | + | + | | + | + | - | - | + | - | - | - |
|OTEL_EXPORTER_JAEGER_* | - | | | | | - | - | | - | - | - |
|OTEL_EXPORTER_JAEGER_* | + | | | | | - | - | | - | + | - |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per the docs in
https://github.com/open-telemetry/opentelemetry-dotnet/tree/main/src/OpenTelemetry.Exporter.Jaeger#environment-variables
only 2 out of the 6 env vars defined in
https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/sdk-environment-variables.md#jaeger-exporter
are supported by otel-dotnet.

Should we state the env vars individually so this is clear or otherwise indicate that it's only partially supported?
There might also be more to come which would void the current + indicators again.

Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for .NET support in Jaeger. I do like @arminru's idea to break out the individual vars for clarity + future-proofing.

@pellared
Copy link
Member Author

break out the individual vars for clarity + future-proofing

I think it would be better to be done in a separate PR. Especially that it would need probably a review from all SIG maintainers.

Copy link
Member

@arminru arminru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

break out the individual vars for clarity + future-proofing

I think it would be better to be done in a separate PR. Especially that it would need probably a review from all SIG maintainers.

@pellared Makes sense 👍

@arminru arminru merged commit 83098f0 into open-telemetry:main Jul 28, 2021
@pellared pellared deleted the patch-1 branch July 28, 2021 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants