Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perform sampling as explained in the specification. #839

Merged
merged 1 commit into from Sep 9, 2022
Merged

Perform sampling as explained in the specification. #839

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
26 changes: 3 additions & 23 deletions opentelemetry-sdk/src/trace/tracer.rs
View file
Open in desktop
Expand Up @@ -152,10 +152,7 @@ impl opentelemetry_api::trace::Tracer for Tracer {
let span_kind = builder.span_kind.take().unwrap_or(SpanKind::Internal);
let mut attribute_options = builder.attributes.take().unwrap_or_default();
let mut link_options = builder.links.take();
let mut no_parent = true;
let mut remote_parent = false;
let mut parent_span_id = SpanId::INVALID;
let mut parent_trace_flags = TraceFlags::default();
let trace_id;

let parent_span = if parent_cx.has_active_span() {
Expand All @@ -166,25 +163,19 @@ impl opentelemetry_api::trace::Tracer for Tracer {

// Build context for sampling decision
if let Some(sc) = parent_span.as_ref().map(|parent| parent.span_context()) {
no_parent = false;
remote_parent = sc.is_remote();
parent_span_id = sc.span_id();
parent_trace_flags = sc.trace_flags();
trace_id = sc.trace_id();
} else {
trace_id = builder
.trace_id
.unwrap_or_else(|| config.id_generator.new_trace_id());
};

// There are 3 paths for sampling.
//
// * Sampling has occurred elsewhere and is already stored in the builder
// * There is no parent or a remote parent, in which case make decision now
// * There is a local parent, in which case defer to the parent's decision
// In order to accomodate use cases like `tracing-opentelemetry` we there is the ability
// to use pre-sampling. Otherwise, the standard method of sampling is followed.
let sampling_decision = if let Some(sampling_result) = builder.sampling_result.take() {
self.process_sampling_result(sampling_result, parent_cx)
} else if no_parent || remote_parent {
} else {
self.make_sampling_decision(
parent_cx,
trace_id,
Expand All @@ -195,17 +186,6 @@ impl opentelemetry_api::trace::Tracer for Tracer {
provider.config(),
&self.instrumentation_lib,
)
} else {
// has parent that is local: use parent if sampled, or don't record.
parent_span
.filter(|span| span.span_context().is_sampled())
.map(|span| {
(
parent_trace_flags,
Vec::new(),
span.span_context().trace_state().clone(),
)
})
};

let SpanBuilder {
Expand Down