Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump thrift to 0.16 #832

Closed
wants to merge 1 commit into from

Conversation

TennyZhuang
Copy link

Signed-off-by: TennyZhuang zty0826@gmail.com

Thrift forget to bump the version on crates.io for a long time, and recently they do it.

Signed-off-by: TennyZhuang <zty0826@gmail.com>
@TennyZhuang TennyZhuang requested a review from a team as a code owner July 4, 2022 06:17
@linux-foundation-easycla
Copy link

CLA Not Signed

@codecov
Copy link

codecov bot commented Jul 4, 2022

Codecov Report

Merging #832 (0ae7a8a) into main (20e46ee) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main    #832   +/-   ##
=====================================
  Coverage   68.7%   68.7%           
=====================================
  Files        115     115           
  Lines       9397    9397           
=====================================
  Hits        6464    6464           
  Misses      2933    2933           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20e46ee...0ae7a8a. Read the comment docs.

Copy link
Contributor

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks like you still need to sign the CLA.

Copy link
Contributor

@TommyCpp TommyCpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The lint issue should be resolved in the main branch.

@TennyZhuang
Copy link
Author

TennyZhuang commented Jul 5, 2022

I’d like to do it, but I always failed to sign with DocSign on every browser, including Safari and latest Chrome. It always warns me that required fields are not filled, but in fact I filled them correctly. Is this a known issue?

Anyway, the change is small, anyone can feel free to help me to resubmit the commit in another PR.

@jtescher
Copy link
Member

This has been resolved in #848

@jtescher jtescher closed this Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants