New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow ref counted keys and values #821
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -34,7 +34,7 @@ serde_json = { version = "1", optional = true} | |
futures = {version = "0.3", optional = true} | ||
async-trait = {version = "0.1", optional = true} | ||
tokio = { version = "1.0", features = ["fs", "io-util"], optional = true } | ||
async-std = { version = "1.6", optional = true } | ||
async-std = { version = "1.10", optional = true } | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Although it probably won't break the MSRV, we should probably pin this to 1.10 to be consistent with other crates? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This was only to get CI passing. Still have to resolve the MSRV issues on main. |
||
|
||
|
||
[dev-dependencies] | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably also implement
AsRef<str>
.