Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow O(1) get operations for SpanBuilder::attributes [breaking] #799

Merged
merged 12 commits into from May 21, 2022
Merged

Allow O(1) get operations for SpanBuilder::attributes [breaking] #799

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
f53ea2b
Use index_map::IndexMap instead of Vec<KeyValue> to store SpanBuilder…
May 17, 2022
0b12dbc
Test suite compiles.
May 17, 2022
3350ad5
Rustfmt
May 17, 2022
3d35871
Wrap IndexMap to expose only the methods that are insertion-order pre…
May 17, 2022
90516dc
Raise MSRV to 1.51 to get support for const generics.
May 17, 2022
19831d4
Fix doctest.
May 17, 2022
0e897a7
Fix lint.
May 17, 2022
c348673
Add specialised implementations to make it easier to work with KeyVal…
May 19, 2022
d08c9bb
Bump MSRV to get access to array::map.
May 19, 2022
2722620
Minimise breakages for existing users.
May 20, 2022
3a6d7a3
Fix invocation.
May 20, 2022
e39fdd4
Rustfmt
May 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Expand Up @@ -68,7 +68,7 @@ jobs:
- uses: actions-rs/toolchain@v1
with:
profile: minimal
toolchain: 1.49.0
toolchain: 1.55.0
override: true
- name: Run tests
run: cargo --version &&
Expand Down
1 change: 1 addition & 0 deletions opentelemetry-api/Cargo.toml
View file
Open in desktop
Expand Up @@ -11,6 +11,7 @@ lazy_static = "1.4"
pin-project = { version = "1.0.2", optional = true }
thiserror = "1"
tokio-stream = { version = "0.1", optional = true }
indexmap = "1"

[package.metadata.docs.rs]
all-features = true
Expand Down
2 changes: 2 additions & 0 deletions opentelemetry-api/src/trace/mod.rs
View file
Open in desktop
Expand Up @@ -168,13 +168,15 @@ use thiserror::Error;

mod context;
pub mod noop;
mod order_map;
mod span;
mod span_context;
mod tracer;
mod tracer_provider;

pub use self::{
context::{get_active_span, mark_span_as_active, FutureExt, SpanRef, TraceContextExt},
order_map::OrderMap,
span::{Span, SpanKind, Status},
span_context::{SpanContext, SpanId, TraceFlags, TraceId, TraceState},
tracer::{SamplingDecision, SamplingResult, SpanBuilder, Tracer},
Expand Down