Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: replace StatusCode and message with Status #760

Merged
merged 2 commits into from Mar 13, 2022
Merged

api: replace StatusCode and message with Status #760

merged 2 commits into from Mar 13, 2022

Commits on Mar 13, 2022

  1. api: replace StatusCode and message with Status 

    The spec defines status as unset, ok, or error with a description. The
current api allows for confusion and misuse by providing invalid
combinations (e.g. Ok with a description). This change simplifies the
api and removes these illegal states by moving the status to be an enum
where only the `Status::Error` case accepts a message.
    @jtescher
    jtescher committed Mar 13, 2022
    Configuration menu
    Copy the full SHA
    11dae40 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into status 

    # Conflicts:
#	opentelemetry-jaeger/src/exporter/mod.rs
    @jtescher
    jtescher committed Mar 13, 2022
    Configuration menu
    Copy the full SHA
    a62ae72 View commit details
    Browse the repository at this point in the history