Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for 0.17.0 release #698

Merged
merged 9 commits into from Jan 22, 2022
Merged

Prepare for 0.17.0 release #698

merged 9 commits into from Jan 22, 2022

Conversation

jtescher
Copy link
Member

@jtescher jtescher commented Jan 9, 2022

No description provided.

@jtescher jtescher requested a review from a team as a code owner January 9, 2022 18:47
@codecov
Copy link

codecov bot commented Jan 9, 2022

Codecov Report

Merging #698 (633cd7c) into main (a81c6c6) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 633cd7c differs from pull request most recent head 552f206. Consider uploading reports for the commit 552f206 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #698      +/-   ##
==========================================
- Coverage   71.38%   71.36%   -0.02%     
==========================================
  Files         101      101              
  Lines        8557     8557              
==========================================
- Hits         6108     6107       -1     
- Misses       2449     2450       +1     
Impacted Files Coverage Δ
opentelemetry-dynatrace/src/transform/metrics.rs 83.33% <100.00%> (ø)
opentelemetry/src/sdk/metrics/controllers/push.rs 80.00% <0.00%> (-3.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a81c6c6...552f206. Read the comment docs.

Copy link
Contributor

@TommyCpp TommyCpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@TommyCpp
Copy link
Contributor

TommyCpp commented Jan 9, 2022

close #690

Thanks for taking care of it 👍

@djc
Copy link
Contributor

djc commented Jan 10, 2022

I was kind of hoping to get a new tonic release with rustls 0.20 support out before this, but so far haven't had a response from the maintainers.

@djc
Copy link
Contributor

djc commented Jan 10, 2022

Also, can we get #694 merged?

@waynexia
Copy link
Contributor

And maybe we can also bump dep prometheus to 0.13? The wrapped registry method returns a 0.12 instance. It's not compatible with some methods in 0.13. In my scenario is gather() in 0.12 against encode() in 0.13. I got this error with the the example:

error message
error[E0308]: mismatched types
  --> prometheus.rs:17:20
   |
17 |     encoder.encode(metric_families.as_slice(), &mut result);
   |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^ expected struct `MetricFamily`, found struct `prometheus::proto::MetricFamily`
   |
   = note: expected reference `&[MetricFamily]`
              found reference `&[prometheus::proto::MetricFamily]`
   = note: perhaps two different versions of crate `prometheus` are being used?

Or we can wrap all methods and users don't need to use prometheus themselves.

@djc
Copy link
Contributor

djc commented Jan 13, 2022

@waynexia could you submit a PR?

# Conflicts:
#	opentelemetry-aws/Cargo.toml
#	opentelemetry-contrib/Cargo.toml
#	opentelemetry-datadog/Cargo.toml
#	opentelemetry-http/Cargo.toml
#	opentelemetry-jaeger/Cargo.toml
#	opentelemetry-otlp/Cargo.toml
#	opentelemetry-prometheus/Cargo.toml
#	opentelemetry-semantic-conventions/Cargo.toml
#	opentelemetry-stackdriver/Cargo.toml
#	opentelemetry-zipkin/Cargo.toml
#	opentelemetry-zpages/Cargo.toml
#	opentelemetry/Cargo.toml
@djc
Copy link
Contributor

djc commented Jan 15, 2022

I'd like to get one more API breaking change into stackdriver on Monday, and will update its changelog.

@jtescher
Copy link
Member Author

@djc sure sounds good

@TommyCpp
Copy link
Contributor

We may also want to merge #707 to bring the new clippy warnings fix.

jtescher and others added 4 commits January 22, 2022 11:11
# Conflicts:
#	opentelemetry-zpages/src/trace/aggregator.rs
Co-authored-by: Dirkjan Ochtman <dirkjan@ochtman.nl>
# Conflicts:
#	opentelemetry-stackdriver/Cargo.toml
Copy link
Contributor

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Looking forward to the release.

@jtescher jtescher merged commit d719eae into open-telemetry:main Jan 22, 2022
@jtescher jtescher deleted the release branch January 22, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants