Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store parent context in span builder #399

Merged
merged 3 commits into from Dec 28, 2020
Merged

Store parent context in span builder #399

merged 3 commits into from Dec 28, 2020

Commits on Dec 27, 2020

  1. Store parent context in span builder 

    The span builder currently holds a parent `SpanContext`, and `Context`
information is passed separately when starting a span directly or via a
builder. This poses a few problems, first you can assign a context which
contains an active span _as well as_ a builder with a parent span
context, which can lead to confusion, and secondly we have to construct
a wrapper context when sampling even in cases when the passed in context
already contains an active span.

This patch resolves this by changing the span builder's parent context
to instead store a `Context` directly. This allows the builder methods
to have a sigle context to look at when searchig for parent span
contexts, and allows the wrapper context to onlly be created for
sampling when it is facilitating a remote parent.
    @jtescher
    jtescher committed Dec 27, 2020
    Configuration menu
    Copy the full SHA
    99382bb View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into builder-parent-context

    @jtescher
    jtescher committed Dec 27, 2020
    Configuration menu
    Copy the full SHA
    0b6502a View commit details
    Browse the repository at this point in the history

  3. Simplify sdk tracer sampling params

    @jtescher
    jtescher committed Dec 27, 2020
    Configuration menu
    Copy the full SHA
    9d38492 View commit details
    Browse the repository at this point in the history