Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit error handling in trace #371

Merged
merged 19 commits into from Nov 30, 2020
Merged

Revisit error handling in trace #371

merged 19 commits into from Nov 30, 2020

Commits on Nov 23, 2020

  1. Add Boxed variant in TraceError enum. 

    It could help propagate error from upstream components.
    @TommyCpp
    TommyCpp committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    128178d View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2020

  1. feat(error_handle): add export errors. 

    Export error will consist two parts.

The first one is two variant in TraceError. One for timed out, the other for all other errors.

The other part is a trait ExportError, which extended the Error trait by asking user to provide the name of the exporter.

Users should implement their own Error for their exporters and implement ExportError on those errors.

(todo): Add errors for all exporters
    @TommyCpp
    TommyCpp committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    ac2ffc8 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2020

  1. feat: add the error type in opentelemetry-zipkin

    @TommyCpp
    TommyCpp committed Nov 26, 2020
    Configuration menu
    Copy the full SHA
    81bc7f2 View commit details
    Browse the repository at this point in the history

  2. feat: add the error type in opentelemetry-otlp

    @TommyCpp
    TommyCpp committed Nov 26, 2020
    Configuration menu
    Copy the full SHA
    7f782f2 View commit details
    Browse the repository at this point in the history

  3. feat: add the error type in opentelemetry-contrib datadog

    @TommyCpp
    TommyCpp committed Nov 26, 2020
    Configuration menu
    Copy the full SHA
    b79b9e0 View commit details
    Browse the repository at this point in the history

  4. feat: add the error type in opentelemetry-jaeger

    @TommyCpp
    TommyCpp committed Nov 26, 2020
    Configuration menu
    Copy the full SHA
    41ce652 View commit details
    Browse the repository at this point in the history

  5. feat: add the error type in opentelemetry testing

    @TommyCpp
    TommyCpp committed Nov 26, 2020
    Configuration menu
    Copy the full SHA
    1b7803e View commit details
    Browse the repository at this point in the history

  6. fix: errors in test and doc.

    @TommyCpp
    TommyCpp committed Nov 26, 2020
    Configuration menu
    Copy the full SHA
    ae0fe86 View commit details
    Browse the repository at this point in the history

  7. fix: format

    @TommyCpp
    TommyCpp committed Nov 26, 2020
    Configuration menu
    Copy the full SHA
    23823d0 View commit details
    Browse the repository at this point in the history

  8. feat: add HttpClientError

    @TommyCpp
    TommyCpp committed Nov 26, 2020
    Configuration menu
    Copy the full SHA
    eea7237 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2020

  1. fix: address comments 

    * Fix typo and naming
* Use thiserror for stdout exporter and datadog exporter
* Implement Error for opentelemetry::Error, renamed from OpenTelemetryError
    @TommyCpp
    TommyCpp committed Nov 28, 2020
    Configuration menu
    Copy the full SHA
    487c33d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of https://github.com/open-telemetry/openteleme… 

    …try-rust into error-handling

� Conflicts:
�	opentelemetry-jaeger/Cargo.toml
    @TommyCpp
    TommyCpp committed Nov 28, 2020
    Configuration menu
    Copy the full SHA
    7c5f135 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2020

  1. fix: address comments 

    * Add ExportError in MetricsError.
It can help unify the export error among trace, metric and logging in the future.

* Merge TraceError::Other into TraceError::Boxed.
Those two seems to have a lot in common. Created a custom wrap type for string and metric those two variants.

* Remove default implement for exporter_name.
It should have used in case like http client failure. But it could also encourage ppl not implement it at all.
    @TommyCpp
    TommyCpp committed Nov 29, 2020
    Configuration menu
    Copy the full SHA
    9ffbace View commit details
    Browse the repository at this point in the history

  2. fix: address comments 

    * Remove HttpClientError
    @TommyCpp
    TommyCpp committed Nov 29, 2020
    Configuration menu
    Copy the full SHA
    fb54263 View commit details
    Browse the repository at this point in the history

  3. fix: fix msrv, address comments and add comments.

    @TommyCpp
    TommyCpp committed Nov 29, 2020
    Configuration menu
    Copy the full SHA
    1180444 View commit details
    Browse the repository at this point in the history

  4. fix: fix msrv

    @TommyCpp
    TommyCpp committed Nov 29, 2020
    Configuration menu
    Copy the full SHA
    1d1f656 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2020

  1. fix: clean the remaining std::error::Error

    @TommyCpp
    TommyCpp committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    5aeeb22 View commit details
    Browse the repository at this point in the history

  2. fix: format

    @TommyCpp
    TommyCpp committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    fa8dae3 View commit details
    Browse the repository at this point in the history

  3. fix: msrv

    @TommyCpp
    TommyCpp committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    47836ea View commit details
    Browse the repository at this point in the history