Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parent based sampling in tracer #354

Merged
merged 3 commits into from Nov 9, 2020
Merged

Fix parent based sampling in tracer #354

merged 3 commits into from Nov 9, 2020

Commits on Nov 9, 2020

  1. Fix parent based sampling in tracer 

    Currently the sdk `Tracer` implementation will filter out invalid /
dropped parent span contexts. This causes the parent based sampler to
not function properly as it will then assume that child spans are roots.

This patch resolves this issue by adding a `has_active_span` method to
the trace context extension, which allows the tracer to distinguish
between invalid and unset parent contexts.
    @jtescher
    jtescher committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    421268c View commit details
    Browse the repository at this point in the history

  2. Fix noop tracer as well

    @jtescher
    jtescher committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    a6edf6e View commit details
    Browse the repository at this point in the history

  3. use all instead for nightly clippy lint

    @jtescher
    jtescher committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    88ddf96 View commit details
    Browse the repository at this point in the history