New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove env_logger from workspace. #1673
base: main
Are you sure you want to change the base?
Conversation
d0a7796
to
57735d1
Compare
- We don't want to include it in the top level workspace as it interferes with MSRV, and doesn't provide benefit. - For MSRV check we just run check. - Also bump to 0.11 in example. Relates open-telemetry#1546,open-telemetry#1554
57735d1
to
9ea90ff
Compare
@@ -93,9 +93,9 @@ jobs: | |||
run: ./scripts/patch_dependencies.sh | |||
- name: Run tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the "Run tests" can be renamed to something more apt to reflect the proposed change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently still some weirdness with the versions
@@ -11,4 +11,4 @@ opentelemetry-jaeger = { path = "../.." } | |||
opentelemetry_sdk = { path = "../../../opentelemetry-sdk" } | |||
actix-web = "4.1" | |||
actix-service = "2" | |||
env_logger = "0.10.0" | |||
env_logger = "0.11.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
env_logger = "0.11.0" | |
env_logger = "0.10.0" |
@@ -93,9 +93,9 @@ jobs: | |||
run: ./scripts/patch_dependencies.sh | |||
- name: Run tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- name: Run tests | |
- name: Check MSRV compatible |
We don't want to include it in the top level workspace as it interferes with MSRV, and doesn't provide benefit.
Also bump to 0.11 in example.
Relates #1546,#1554
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes