Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename duplicate examples #1645

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

demoray
Copy link

@demoray demoray commented Mar 26, 2024

When testing the at the workspace level, there are warnings about duplicate examples which may become a hard error from rust. This PR renames the examples.

❯ cargo test --release
warning: output filename collision.
The example target `basic` in package `opentelemetry-stdout v0.3.0 (/REDACTED/opentelemetry-rust/opentelemetry-stdout)` has the same output filename as the example target `basic` in package
`opentelemetry-appender-tracing v0.3.0 (/HOME/opentelemetry-rust/opentelemetry-appender-tracing)`.
Colliding filename is: /REDACTED/opentelemetry-rust/target/release/examples/basic
The targets should have unique names.  Consider changing their names to be unique or compiling them separately.  This may become a hard error in the future; see <https://github.com/rust-lang/cargo/issues/6313>.
warning: output filename collision.
The example target `basic` in package `opentelemetry-stdout v0.3.0 (/REDACTED/opentelemetry-rust/opentelemetry-stdout)` has the same output filename as the example target `basic` in package `opentelemetry-appender-tracing v0.3.0 (/REDACTED/opentelemetry-rust/opentelemetry-appender-tracing)`.
Colliding filename is: /REDACTED/opentelemetry-rust/target/release/examples/basic
The targets should have unique names.  Consider changing their names to be unique or compiling them separately.  This may become a hard error in the future; see <https://github.com/rust-lang/cargo/issues/6313>.

Fixes #
Design discussion issue (if applicable) #

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

When testing the at the workspace level, there are warnings about
duplicate examples which may become a hard error from rust.  This PR
renames the examples.

```
❯ cargo test --release
warning: output filename collision.
The example target `basic` in package `opentelemetry-stdout v0.3.0 (/REDACTED/opentelemetry-rust/opentelemetry-stdout)` has the same output filename as the example target `basic` in package
`opentelemetry-appender-tracing v0.3.0 (/HOME/opentelemetry-rust/opentelemetry-appender-tracing)`.
Colliding filename is: /REDACTED/opentelemetry-rust/target/release/examples/basic
The targets should have unique names.  Consider changing their names to be unique or compiling them separately.  This may become a hard error in the future; see <rust-lang/cargo#6313>.
warning: output filename collision.
The example target `basic` in package `opentelemetry-stdout v0.3.0 (/REDACTED/opentelemetry-rust/opentelemetry-stdout)` has the same output filename as the example target `basic` in package `opentelemetry-appender-tracing v0.3.0 (/REDACTED/opentelemetry-rust/opentelemetry-appender-tracing)`.
Colliding filename is: /REDACTED/opentelemetry-rust/target/release/examples/basic
The targets should have unique names.  Consider changing their names to be unique or compiling them separately.  This may become a hard error in the future; see <rust-lang/cargo#6313>.
```
@demoray demoray requested a review from a team as a code owner March 26, 2024 16:19
Copy link

linux-foundation-easycla bot commented Mar 26, 2024

CLA Missing ID CLA Not Signed

@lalitb
Copy link
Member

lalitb commented Mar 27, 2024

Should we also update the comment in these examples :

Also, you have to sign the CLA for CI to succeed, and enable merging.

@demoray
Copy link
Author

demoray commented Mar 29, 2024

Should we also update the comment in these examples :

Done

Also, you have to sign the CLA for CI to succeed, and enable merging.

I've submitted a request to our CLA manager through the EasyCLA system.

Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.9%. Comparing base (278f5c7) to head (2dec5a8).
Report is 2 commits behind head on main.

❗ Current head 2dec5a8 differs from pull request most recent head 6e4aac1. Consider uploading reports for the commit 6e4aac1 to get more accurate results

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1645   +/-   ##
=====================================
  Coverage   68.9%   68.9%           
=====================================
  Files        136     136           
  Lines      19429   19429           
=====================================
  Hits       13396   13396           
  Misses      6033    6033           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lalitb lalitb added the S-blocked-cla Status: Issues blocked on CLA label Mar 29, 2024
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once CLA is signed.

@cijothomas
Copy link
Member

Should we also update the comment in these examples :

Done

Also, you have to sign the CLA for CI to succeed, and enable merging.

I've submitted a request to our CLA manager through the EasyCLA system.

@demoray any luck with the CLA signing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-blocked-cla Status: Issues blocked on CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants