New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename duplicate examples #1645
base: main
Are you sure you want to change the base?
rename duplicate examples #1645
Conversation
When testing the at the workspace level, there are warnings about duplicate examples which may become a hard error from rust. This PR renames the examples. ``` ❯ cargo test --release warning: output filename collision. The example target `basic` in package `opentelemetry-stdout v0.3.0 (/REDACTED/opentelemetry-rust/opentelemetry-stdout)` has the same output filename as the example target `basic` in package `opentelemetry-appender-tracing v0.3.0 (/HOME/opentelemetry-rust/opentelemetry-appender-tracing)`. Colliding filename is: /REDACTED/opentelemetry-rust/target/release/examples/basic The targets should have unique names. Consider changing their names to be unique or compiling them separately. This may become a hard error in the future; see <rust-lang/cargo#6313>. warning: output filename collision. The example target `basic` in package `opentelemetry-stdout v0.3.0 (/REDACTED/opentelemetry-rust/opentelemetry-stdout)` has the same output filename as the example target `basic` in package `opentelemetry-appender-tracing v0.3.0 (/REDACTED/opentelemetry-rust/opentelemetry-appender-tracing)`. Colliding filename is: /REDACTED/opentelemetry-rust/target/release/examples/basic The targets should have unique names. Consider changing their names to be unique or compiling them separately. This may become a hard error in the future; see <rust-lang/cargo#6313>. ```
|
Should we also update the comment in these examples :
Also, you have to sign the CLA for CI to succeed, and enable merging. |
Done
I've submitted a request to our CLA manager through the EasyCLA system. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1645 +/- ##
=====================================
Coverage 68.9% 68.9%
=====================================
Files 136 136
Lines 19429 19429
=====================================
Hits 13396 13396
Misses 6033 6033 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once CLA is signed.
@demoray any luck with the CLA signing? |
When testing the at the workspace level, there are warnings about duplicate examples which may become a hard error from rust. This PR renames the examples.
Fixes #
Design discussion issue (if applicable) #
Changes
Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes