Allow ref counted keys and values #821
Conversation
This updates attribute `Key` and `Value` inner types from `Cow<'static, str>` to a new private `OtelString` enum to support static, owned, or ref counted values.
Codecov Report
@@ Coverage Diff @@
## main #821 +/- ##
=====================================
Coverage 69.8% 69.8%
=====================================
Files 110 110
Lines 9072 9148 +76
=====================================
+ Hits 6333 6388 +55
- Misses 2739 2760 +21
Continue to review full report at Codecov.
|
| @@ -34,7 +34,7 @@ serde_json = { version = "1", optional = true} | |||
| futures = {version = "0.3", optional = true} | |||
| async-trait = {version = "0.1", optional = true} | |||
| tokio = { version = "1.0", features = ["fs", "io-util"], optional = true } | |||
| async-std = { version = "1.6", optional = true } | |||
| async-std = { version = "1.10", optional = true } | |||
There was a problem hiding this comment.
Although it probably won't break the MSRV, we should probably pin this to 1.10 to be consistent with other crates?
There was a problem hiding this comment.
This was only to get CI passing. Still have to resolve the MSRV issues on main.
opentelemetry-api/src/common.rs
Outdated
| ); | ||
|
|
||
| impl From<Vec<&'static str>> for Array { | ||
| /// Convenience method for creating a `Value` from a `&'static str`. |
There was a problem hiding this comment.
The comments here are slightly wrong/misleading IMO.
Are these conversions especially common across the other crates? It feels like these might make it easy to do something relatively inefficient, so maybe we should leave the conversion to particular call sites?
|
|
||
| impl StringValue { | ||
| /// Returns a string slice to this value | ||
| pub fn as_str(&self) -> &str { |
There was a problem hiding this comment.
Should probably also implement AsRef<str>.
| "process.command_args", | ||
| Value::Array(Array::String(cmd_arg_val)), | ||
| ), | ||
| KeyValue::new("process.command_args", Value::Array(cmd_arg_val.into())), |
There was a problem hiding this comment.
For example here we first allocate a Vec<String> and then cmd_arg_val.into() will allocate a new Vec<StringValue>, redoing the outer allocation.
This updates attribute
KeyandValueinner types fromCow<'static, str>to a new privateOtelStringenum to support static, owned, or ref counted values.Resolves #809