Store parent context in span builder #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The span builder currently holds a parent `SpanContext`, and `Context` information is passed separately when starting a span directly or via a builder. This poses a few problems, first you can assign a context which contains an active span _as well as_ a builder with a parent span context, which can lead to confusion, and secondly we have to construct a wrapper context when sampling even in cases when the passed in context already contains an active span. This patch resolves this by changing the span builder's parent context to instead store a `Context` directly. This allows the builder methods to have a sigle context to look at when searchig for parent span contexts, and allows the wrapper context to onlly be created for sampling when it is facilitating a remote parent.
TommyCpp
reviewed
Dec 27, 2020
Codecov Report
@@ Coverage Diff @@
## master #399 +/- ##
==========================================
- Coverage 49.12% 49.11% -0.02%
==========================================
Files 66 66
Lines 5394 5400 +6
==========================================
+ Hits 2650 2652 +2
- Misses 2744 2748 +4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The span builder currently holds a parent
SpanContext, andContextinformation is passed separately when starting a span directly or via a builder. This poses a few problems, first you can assign a context which contains an active span as well as a builder with a parent span context, which can lead to confusion, and secondly we have to construct a wrapper context when sampling even in cases when the passed in context already contains an active span.This patch resolves this by changing the span builder's parent context to instead store a
Contextdirectly. This allows the builder methods to have a single context to look at when searching for parent span contexts, and allows the wrapper context to only be created for sampling when it is facilitating a remote parent.