Fix parent based sampling in tracer #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the sdk `Tracer` implementation will filter out invalid / dropped parent span contexts. This causes the parent based sampler to not function properly as it will then assume that child spans are roots. This patch resolves this issue by adding a `has_active_span` method to the trace context extension, which allows the tracer to distinguish between invalid and unset parent contexts.
Codecov Report
@@ Coverage Diff @@
## master #354 +/- ##
==========================================
+ Coverage 54.03% 54.19% +0.15%
==========================================
Files 70 70
Lines 5833 5849 +16
==========================================
+ Hits 3152 3170 +18
+ Misses 2681 2679 -2
Continue to review full report at Codecov.
|
frigus02
approved these changes
Nov 9, 2020
frigus02
approved these changes
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the sdk
Tracerimplementation will filter out invalid / dropped parent span contexts. This causes the parent based sampler to not function properly as it will then assume that child spans are roots.This patch resolves this issue by adding a
has_active_spanmethod to the trace context extension, which allows the tracer to distinguish between invalid and unset parent contexts.Fixes #351