Fix SpanRef::set_attributes mutability (#1038)

open-telemetry · Apr 24, 2023 · a9399e9 · a9399e9
1 parent d560ff3
commit a9399e9
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/opentelemetry-api/CHANGELOG.md b/opentelemetry-api/CHANGELOG.md
@@ -1,5 +1,11 @@
 # Changelog
 
+## Unreleased
+
+### Fixed
+
+- Fix `SpanRef::set_attributes` mutability requirement. [#1038](https://github.com/open-telemetry/opentelemetry-rust/pull/1038)
+
 ## v0.19.0
 ### Added
 - Add `WithContext` to public api [#893](https://github.com/open-telemetry/opentelemetry-rust/pull/893).

diff --git a/opentelemetry-api/src/trace/context.rs b/opentelemetry-api/src/trace/context.rs
@@ -139,7 +139,7 @@ impl SpanRef<'_> {
     ///
     /// [standard attributes]: https://github.com/open-telemetry/opentelemetry-specification/blob/v1.9.0/specification/trace/semantic_conventions/README.md
     /// [opentelemetry_semantic_conventions]: https://docs.rs/opentelemetry-semantic-conventions
-    pub fn set_attributes(&mut self, attributes: impl IntoIterator<Item = KeyValue>) {
+    pub fn set_attributes(&self, attributes: impl IntoIterator<Item = KeyValue>) {
         self.with_inner_mut(move |inner| inner.set_attributes(attributes))
     }