Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Upgrade rubocop 0.73 -> 1.3 for TestHelpers #1392

Merged
merged 2 commits into from Oct 24, 2022
Merged

chore: Upgrade rubocop 0.73 -> 1.3 for TestHelpers #1392

merged 2 commits into from Oct 24, 2022

Conversation

richardmcmillen
Copy link
Contributor

@richardmcmillen richardmcmillen commented Oct 24, 2022 •
edited

Partially addresses: #1321

@richardmcmillen richardmcmillen marked this pull request as draft October 24, 2022 04:22
@richardmcmillen richardmcmillen force-pushed the upgrade-rubocop-test-helpers branch 2 times, most recently from abf087e to 7c1e6cc Compare October 24, 2022 04:37
@richardmcmillen
chore: Upgrade rubocop 0.73 -> 1.3 for TestHelpers
2972dd8 
* enable all new cops by default
* Style/BracesAroundHashParameters was removed - see rubocop/rubocop#7641
* LineLength changed group from Metrics to Layout
* disable Gemspec/RequireMFA
* autocorrect explicit block over yield
@richardmcmillen richardmcmillen marked this pull request as ready for review October 24, 2022 04:41
ahayworth
ahayworth approved these changes Oct 24, 2022
View reviewed changes
Copy link
Contributor

@ahayworth ahayworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% sure about enabling new cops (we may find ourselves annoyed with that someday), but I don't think that's a blocking concern - we can always turn it back off. 😄

LGTM, thanks!

@robertlaurin robertlaurin merged commit d3c9353 into open-telemetry:main Oct 24, 2022
@richardmcmillen richardmcmillen deleted the upgrade-rubocop-test-helpers branch October 25, 2022 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahayworth ahayworth ahayworth approved these changes

@robertlaurin robertlaurin robertlaurin approved these changes

@fbogsany fbogsany Awaiting requested review from fbogsany fbogsany is a code owner

@mwear mwear Awaiting requested review from mwear mwear is a code owner

@dazuma dazuma Awaiting requested review from dazuma dazuma is a code owner

@ericmustin ericmustin Awaiting requested review from ericmustin ericmustin is a code owner

@arielvalentin arielvalentin Awaiting requested review from arielvalentin arielvalentin is a code owner

@plantfansam plantfansam Awaiting requested review from plantfansam plantfansam is a code owner

@robbkidd robbkidd Awaiting requested review from robbkidd robbkidd is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@richardmcmillen @ahayworth @robertlaurin