Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort by label keys before generating labels key and value lists #3698

Merged
merged 13 commits into from
Apr 17, 2024
Merged

Sort by label keys before generating labels key and value lists #3698

Changes from 4 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
364f704
sort by label keys
soundofspace Feb 22, 2024
18308db
Merge branch 'main' into Fix-bug-when-labels-are-ordered-differently
soundofspace Feb 28, 2024
6a2fe89
Merge branch 'main' into Fix-bug-when-labels-are-ordered-differently
soundofspace Mar 2, 2024
4c5a2a0
Merge branch 'main' into Fix-bug-when-labels-are-ordered-differently
lzchen Mar 7, 2024
729aa22
changelog
soundofspace Mar 22, 2024
833acee
test
soundofspace Mar 22, 2024
3f97bac
Merge branch 'main' into Fix-bug-when-labels-are-ordered-differently
soundofspace Mar 22, 2024
f676245
Merge branch 'main' into Fix-bug-when-labels-are-ordered-differently
soundofspace Apr 15, 2024
19916f6
review
soundofspace Apr 17, 2024
2c526cd
Merge branch 'main' into Fix-bug-when-labels-are-ordered-differently
soundofspace Apr 17, 2024
970679c
Merge branch 'main' into Fix-bug-when-labels-are-ordered-differently
lzchen Apr 17, 2024
9f8046f
linting
soundofspace Apr 17, 2024
ef6fd85
Update contrib SHA
ocelotl Apr 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion exporter/opentelemetry-exporter-prometheus/src/opentelemetry/exporter/prometheus/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ def _translate_to_prometheus(
label_keys = []
label_values = []

for key, value in number_data_point.attributes.items():
for key, value in sorted(number_data_point.attributes.items()):
soundofspace marked this conversation as resolved.
Show resolved Hide resolved
label_keys.append(self._sanitize(key))
label_values.append(self._check_value(value))

Expand Down