Add exponential Histogram #2930
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocelotl
force-pushed
the
issue_2421
branch
28 times, most recently
from
d7b3317
to
57d8834
Compare
jmacd
reviewed
Sep 29, 2022
There was a problem hiding this comment.
This may be too large to ask reviewers to review all at once. We are facing similar questions in the OTel-Go group, where I've proposed the corresponding be split into parts:
- The mapping functions
- The basic data structure
- The integration into the SDK
See the latest effort to merge just the mapping functions, which has links to the other draft parts: open-telemetry/opentelemetry-go#3243
opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/exponential/buckets.py
Outdated
Show resolved
Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/exponential/aggregation.py
Show resolved
Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/exponential/aggregation.py
Show resolved
Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/exponential/aggregation.py
Outdated
Show resolved
Hide resolved
|
|
||
| index = self._mapping.map_to_index(value) | ||
|
|
||
| low, high, success = self._increment_index_by(buckets, index, incr) |
There was a problem hiding this comment.
Suggest keeping the order of low, high the same as below, where it's high, low.
opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/exponential/aggregation.py
Show resolved
Hide resolved
| return number | ||
|
|
||
|
|
||
| def _with(h_low, h_high, o_low, o_high): |
There was a problem hiding this comment.
suggest a longer name like combineHighAndLow()
opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/exponential/buckets.py
Show resolved
Hide resolved
…nential/aggregation.py Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
…nential/buckets.py Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
|
Closing this PR to split it in smaller PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2421