Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added conditional calling of unary_unary etc functions in _InterceptorChannel #2484

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

added conditional calling of unary_unary etc functions in _InterceptorChannel #2484

wants to merge 11 commits into from

Conversation

VamsiKrishna1211
Copy link

@VamsiKrishna1211 VamsiKrishna1211 commented Apr 30, 2024 •
edited

Fixes #2483

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Installing the grpc contrib package along with grpc>=1.63.0 version.

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Apr 30, 2024 •
edited

CLA Missing ID CLA Not Signed

@VamsiKrishna1211 VamsiKrishna1211 marked this pull request as ready for review April 30, 2024 19:57
@xrmx
Copy link
Contributor

xrmx commented May 2, 2024 •
edited

@VamsiKrishna1211 care to add a test with updated test requirements so we can actually test it in CI?

@VamsiKrishna1211
Copy link
Author

@xrmx Yes sure.
This is my first contribution to otel-contrib repository.
So please let me know if I have to make any other changes in the PR. :)

@xrmx
Copy link
Contributor

xrmx commented May 2, 2024

@xrmx Yes sure. This is my first contribution to otel-contrib repository. So please let me know if I have to make any other changes in the PR. :)

Cool! tests and an entry in CHANGELOG should be enough

@VamsiKrishna1211
Copy link
Author

Cool! tests and an entry in CHANGELOG should be enough

@xrmx The changes in the PR pertain to instrumentation-grpc only, and I need to test with multiple versions of grpcio package. More specifically grpcio>=1.63.0 and grpcio<1.63.0. Because there is a breaking change introduced in the methods of Channel class in latest release of grpcio==1.63.0.

Is there any standard way already you guys follow to test these kind of scenarios?

@xrmx
Copy link
Contributor

xrmx commented May 3, 2024 •
edited

@VamsiKrishna1211 you can take a look at opentelemetry-instrumentation-httpx both in tox.ini (grep for httpx) and in the instrumentation package dir

@VamsiKrishna1211 VamsiKrishna1211 requested a review from a team as a code owner May 3, 2024 20:00
@VamsiKrishna1211 VamsiKrishna1211 marked this pull request as draft May 3, 2024 20:01
xrmx
xrmx reviewed May 3, 2024
View reviewed changes
tox.ini Outdated Show resolved Hide resolved
instrumentation/opentelemetry-instrumentation-grpc/test-requirements-1.txt Outdated Show resolved Hide resolved
@VamsiKrishna1211 VamsiKrishna1211 marked this pull request as ready for review May 3, 2024 20:08
xrmx
xrmx reviewed May 15, 2024
View reviewed changes
tox.ini Outdated Show resolved Hide resolved
VamsiKrishna1211 and others added 2 commits May 17, 2024 10:32
@VamsiKrishna1211 @xrmx
Update instrumentation/opentelemetry-instrumentation-grpc/src/opentel…
b92030e 
…emetry/instrumentation/grpc/grpcext/_interceptor.py

Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
@VamsiKrishna1211 @xrmx
Update instrumentation/opentelemetry-instrumentation-grpc/src/opentel…
1e87c88 
…emetry/instrumentation/grpc/grpcext/_interceptor.py

Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
@VamsiKrishna1211
Copy link
Author

@xrmx Thanks for correcting the _registered_method argument, I think missed it by accident.

@xrmx xrmx requested a review from aabmass May 17, 2024 07:15
@xrmx
Copy link
Contributor

xrmx commented May 20, 2024 •
edited

@VamsiKrishna1211 could you please add a CHANGELOG entry? And fix lint and CLA please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrmx xrmx xrmx approved these changes

@aabmass aabmass Awaiting requested review from aabmass

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error with the latest grpc version (v1.63.0)
3 participants
@VamsiKrishna1211 @xrmx @tammy-baylis-swi