Fix dependency notes in tox.ini #2481
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #24800
aabmass
requested changes
Apr 30, 2024
| @@ -100,9 +100,9 @@ envlist = | |||
| ; py310 does not work with falcon 1 | |||
| ; The numbers at the end of the environment names | |||
| ; below mean these dependencies are being used: | |||
| ; 0: falcon ==1.4.1 | |||
| ; 1: falcon >=2.0.0,<3.0.0 | |||
| ; 2: falcon >=3.0.0,<4.0.0 | |||
There was a problem hiding this comment.
I thought the goal of these comments was to preserve the actual range so when it comes time to upgrade the pinned version, we can make sure it meets this requirement?
| ; 2: Flask >=3.0.0 Werkzeug >=3.0.0 | ||
| ; 0: Flask==2.1.3 Werkzeug==2.3.8 | ||
| ; 1: Flask==2.2.0 Werkzeug==2.3.8 | ||
| ; 2: Flask==3.0.2 Werkzeug==3.0.1 |
There was a problem hiding this comment.
I'm a bit confused what's going on here. This version constraint is impossible to fulfill
How did we get here? 😅
| @@ -116,9 +116,9 @@ envlist = | |||
| ; opentelemetry-instrumentation-flask | |||
| ; The numbers at the end of the environment names | |||
| ; below mean these dependencies are being used: | |||
| ; 0: Flask ==2.1.3 Werkzeug <3.0.0 | |||
| ; 1: Flask ==2.2.0 Werkzeug <3.0.0 | |||
| ; 2: Flask >=3.0.0 Werkzeug >=3.0.0 | |||
There was a problem hiding this comment.
These are the same number, something went wrong?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24800