Allow broad exceptions in pylint #2471
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xrmx
reviewed
Apr 29, 2024
So, I tried this approach because it was the one that worked for the core repo. |
xrmx
requested changes
May 9, 2024
xrmx
reviewed
May 14, 2024
| @@ -81,7 +81,8 @@ disable=missing-docstring, | |||
| missing-module-docstring, # temp-pylint-upgrade | |||
| import-error, # needed as a workaround as reported here: https://github.com/open-telemetry/opentelemetry-python-contrib/issues/290 | |||
| cyclic-import, | |||
| not-context-manager | |||
| not-context-manager, | |||
| broad-exception-raised | |||
There was a problem hiding this comment.
this should not be added then
There was a problem hiding this comment.
Did that and lint failed.
There was a problem hiding this comment.
@ocelotl I've opened a draft PR to fix them, failing because I got some the pylint exception wrong and missed to update tests when used different Exception types, will update it tomorrow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2470