DO NOT MERGE: Auto instrumentation paramaters proposal #2439
+10
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremydvoss
changed the title
|
Closing because custom configurators can handle kwargs instead. No need for the distros to return anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the only way for custom distros to configure is through setting or defaulting environment variables. While it makes sense for customers to configure distros with env vars. There is no reason distros should need be able to directly configure start up (exporters, samplers...etc). Exposing distro configuration of otel via env var defaults is invasive, confusing, and easy for users to mess up. For instrance, even a blank env var or a left over setting from previous run could interfere with a distro starting up.
This is a draft proposal for what changing this approach could look like. In this approach, distros can output kwargs that our sitecustomize setup can then pass to configurators, and by extension the _initialize_components method which currently only considers env vars.
main repo pr: open-telemetry/opentelemetry-python#3864
contrib pr: #2439