Relax httpx version to allow >= 0.18.0

[phillipuniverse]

Description

The tests were failing in httpx > 0.23.1 because of this change in httpx - encode/httpx#2407

Pretty easy workaround illustrated in the changed tests in that PR

Fixes #1463, #1460 and #1459.

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Automated tests caught the failure and validated the fix

Does This PR Require a Core Repo Change?

• Yes. - Link to PR:
• No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

• Followed the style guidelines of this project
• Changelogs have been updated
• Unit tests have been added
• Documentation has been updated

[phillipuniverse]

This is the test failure:

=================================== FAILURES ===================================
__ TestStarletteManualInstrumentation.test_basic_post_request_metric_success ___

self = <tests.test_starlette_instrumentation.TestStarletteManualInstrumentation testMethod=test_basic_post_request_metric_success>

    def test_basic_post_request_metric_success(self):
        start = default_timer()
        expected_duration_attributes = {
            "http.flavor": "1.1",
            "http.host": "testserver",
            "http.method": "POST",
            "http.scheme": "http",
            "http.server_name": "testserver",
            "http.status_code": 405,
            "net.host.port": 80,
        }
        expected_requests_count_attributes = {
            "http.flavor": "1.1",
            "http.host": "testserver",
            "http.method": "POST",
            "http.scheme": "http",
            "http.server_name": "testserver",
        }
        self._client.post("/foobar")
        duration = max(round((default_timer() - start) * 1000), 0)
        metrics_list = self.memory_metrics_reader.get_metrics_data()
        for metric in (
            metrics_list.resource_metrics[0].scope_metrics[0].metrics
        ):
            for point in list(metric.data.data_points):
                if isinstance(point, HistogramDataPoint):
                    self.assertEqual(point.count, 1)
>                   self.assertAlmostEqual(duration, point.sum, delta=30)
E                   AssertionError: 34 != 3 within 30 delta (31 difference)

test_starlette_instrumentation.py:175: AssertionError
========================= 1 failed, 49 passed in 2.26s =========================

It's over in Starlette and maybe this is a flaky one?

[macieyng]

@lzchen @jeremydvoss please review this PR 🙏

[macieyng]

@phillipuniverse can you take a look at the pipeline?

[ocelotl]

@phillipuniverse almost there! please resolve the conflicts 👍 we should be able to merge this one soon with a bit of luck.

[phillipuniverse]

@ocelotl @macieyng done

[phillipuniverse]

The latest test failure looks like a flaky one in aiohttp

[phillipuniverse]

Unfortunately I can't manually re-run the build, @ocelotl can you?

[phillipuniverse]

@lzchen @jeremydvoss @ocelotl this has been open for almost 6.5 weeks. What can I do here to reduce the turnaround cycles?

[ocelotl]

@lzchen @jeremydvoss @ocelotl this has been open for almost 6.5 weeks. What can I do here to reduce the turnaround cycles?

Sorry! we've been quite low on people who can review, reviewing this right now...

[macieyng]

@phillipuniverse I'm trying to understand the consequences before this was merged. Assuming I had httpx==0.24.1 and opentelemetry-instrumentation-httpx==0.38b0 would it mean that my httpx was not instrumented due to that reason?

Because right now I don't really see httpx dependencies/traces and I'm not sure if this is the reason or I have something misconfigured.

[phillipuniverse]

@macieyng yes that is probably the reason.