-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow broad exceptions in pylint #2471
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No strong opinion, but why not keeping the check and just use builtins.Exception
in the config?
So, I tried this approach because it was the one that worked for the core repo. |
@@ -81,7 +81,8 @@ disable=missing-docstring, | |||
missing-module-docstring, # temp-pylint-upgrade | |||
import-error, # needed as a workaround as reported here: https://github.com/open-telemetry/opentelemetry-python-contrib/issues/290 | |||
cyclic-import, | |||
not-context-manager | |||
not-context-manager, | |||
broad-exception-raised |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should not be added then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did that and lint
failed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ocelotl I've opened a draft PR to fix them, failing because I got some the pylint exception wrong and missed to update tests when used different Exception types, will update it tomorrow
Fixes #2470