Add resource attributes and scope to metrics proto diagram #519
Conversation
| // |unit | +------------------------------------+ | ||
| // |data |---> |Gauge, Sum, Histogram, Summary, ... | | ||
| // +------------+ +------------------------------------+ | ||
| // MetricsData |
There was a problem hiding this comment.
Why provide a definition of the MetricsData type for the Metric? This seems more appropriate in the MetricsData type documentation.
There was a problem hiding this comment.
@jsuereth, @tigrannajaryan what do you think? Should I move this up?
There was a problem hiding this comment.
Works either for me, as long as we have this diagram somewhere.
There was a problem hiding this comment.
@tigrannajaryan, I just pushed a commit. Can you please take a look?
krisztianfekete
force-pushed
the
add-resource-attributes-scope
branch
2 times, most recently
from
893bb76
to
aabc9cb
Compare
| // Metric | ||
| // +------------+ | ||
| // |name | | ||
| // |description | | ||
| // |unit | +------------------------------------+ | ||
| // |data |---> |Gauge, Sum, Histogram, Summary, ... | | ||
| // +------------+ +------------------------------------+ | ||
| // |
There was a problem hiding this comment.
This doesn't need to be removed. It contextualizes the following diagram about metric data.
There was a problem hiding this comment.
I removed that based on @bogdandrutu's advice: #519 (comment)
There was a problem hiding this comment.
His comment was made when this PR was changing the documentation of this declaration. It doesn't seem relevant to me given this PR has moved the added documentation elsewhere.
krisztianfekete
force-pushed
the
add-resource-attributes-scope
branch
from
214b6c7
to
20d664f
Compare
Fixes #518.