Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declare Trace part of OTLP Stable #160

Merged
merged 1 commit into from
Jun 24, 2020
Merged

Declare Trace part of OTLP Stable #160

merged 1 commit into from
Jun 24, 2020

Conversation

tigrannajaryan
Copy link
Member

Resolves: #154

bogdandrutu
bogdandrutu approved these changes Jun 22, 2020
View reviewed changes
Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RC instead of stable? We will have comments like your version is 0.x how can this be stable, saw that

@tigrannajaryan
Copy link
Member Author

We don't have a formal definition for "RC" in our maturity matrix: https://github.com/open-telemetry/community/blob/47813530864b9fe5a5146f466a58bd2bb94edc72/maturity-matrix.yaml#L57 so using "RC" may invite more questions.

@carlosalberto
Copy link
Contributor

Merging, after deciding in the latest Specification SIG call that we will have this support in the proto/collector part.

@carlosalberto carlosalberto merged commit 1a931b4 into open-telemetry:master Jun 24, 2020
@tigrannajaryan tigrannajaryan deleted the feature/tigran/tracestable branch June 24, 2020 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosalberto carlosalberto carlosalberto approved these changes

@bogdandrutu bogdandrutu bogdandrutu approved these changes

@fbogsany fbogsany fbogsany approved these changes

@yurishkuro yurishkuro yurishkuro approved these changes

@jmacd jmacd jmacd approved these changes

@arminru arminru arminru approved these changes

@c24t c24t Awaiting requested review from c24t

@iredelmeier iredelmeier Awaiting requested review from iredelmeier

@reyang reyang Awaiting requested review from reyang

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

@tedsuo tedsuo Awaiting requested review from tedsuo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Declare Trace part of the protocol as Stable
7 participants
@tigrannajaryan @carlosalberto @bogdandrutu @fbogsany @yurishkuro @jmacd @arminru