Add messages to support Log data type #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigrannajaryan
requested review from
arminru,
bogdandrutu,
c24t,
carlosalberto,
iredelmeier,
jmacd,
reyang,
SergeyKanzhelev,
tedsuo and
yurishkuro
as code owners
8 tasks
|
@open-telemetry/specs-approvers please review. |
SergeyKanzhelev
suggested changes
Jun 2, 2020
|
@SergeyKanzhelev thanks for reviewing. I am experimenting with a slightly different approach. Let me mark this PR as WIP and I will update it once I finish the experiments. |
tigrannajaryan
changed the title
|
I will return to this once #157 is merged. |
tigrannajaryan
force-pushed
the
feature/tigran/logproto
branch
from
9a7bb9a
to
10fc39b
Compare
tigrannajaryan
changed the title
|
@open-telemetry/specs-approvers please have a look. I updated the PR. |
tigrannajaryan
force-pushed
the
feature/tigran/logproto
branch
from
10fc39b
to
a6e188c
Compare
This definition is based on the accepted log data model: https://github.com/open-telemetry/oteps/blob/master/text/logs/0097-log-data-model.md LogsService is defined similarly to TraceService and MetricsService.
tigrannajaryan
force-pushed
the
feature/tigran/logproto
branch
from
a6e188c
to
4413255
Compare
kumoroku
reviewed
Jun 29, 2020
odsod
reviewed
Jun 30, 2020
odsod
reviewed
Jun 30, 2020
bogdandrutu
approved these changes
Jun 30, 2020
tigrannajaryan
force-pushed
the
feature/tigran/logproto
branch
from
29ea1b1
to
34520b5
Compare
tigrannajaryan
force-pushed
the
feature/tigran/logproto
branch
from
34520b5
to
ea6969a
Compare
|
@SergeyKanzhelev can you please review. |
kumoroku
approved these changes
Jul 6, 2020
yurishkuro
reviewed
Jul 8, 2020
yurishkuro
approved these changes
Jul 8, 2020
|
@SergeyKanzhelev can you please have another look. You requested changes, I believe everything is addressed now. |
tigrannajaryan
force-pushed
the
feature/tigran/logproto
branch
from
7d1090c
to
29e4e4f
Compare
|
@open-telemetry/specs-approvers please review. |
carlosalberto
approved these changes
Jul 15, 2020
SergeyKanzhelev
approved these changes
Jul 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This definition is based on the accepted log data model:
https://github.com/open-telemetry/oteps/blob/master/text/logs/0097-log-data-model.md
LogsService is defined similarly to TraceService and MetricsService.