Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: .editorconfig, .gitattributes #207

Merged
merged 2 commits into from
Nov 3, 2020

Conversation

dkarlovi
Copy link
Contributor

@dkarlovi dkarlovi commented Nov 3, 2020

This adds two QoL files.

.editorconfig

Ensures a baseline of file formatting across all files added to the repo, see https://editorconfig.org/

.gitattributes

Removes everything not required for production from the Git export of the repo, which is used by Github to create releases used by Composer. This is considered best practice and done by a lot of packages already, see https://twitter.com/dkarlovi/status/1098495571214692352

@codecov
Copy link

codecov bot commented Nov 3, 2020

Codecov Report

Merging #207 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #207   +/-   ##
=========================================
  Coverage     91.56%   91.56%           
  Complexity      312      312           
=========================================
  Files            36       36           
  Lines           735      735           
=========================================
  Hits            673      673           
  Misses           62       62           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a55169c...d1a04e0. Read the comment docs.

@dkarlovi
Copy link
Contributor Author

dkarlovi commented Nov 3, 2020

Suggest merging this one after #205 so there's no conflicts.

@bobstrecansky bobstrecansky merged commit 2664984 into open-telemetry:master Nov 3, 2020
@dkarlovi dkarlovi deleted the chore/editorconfig branch November 3, 2020 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants