feat: implement cloud{provider,platform}, aws.{ecs.*,log.*} in ECS detector #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #83 +/- ##
============================================
+ Coverage 89.58% 89.67% +0.09%
- Complexity 283 298 +15
============================================
Files 31 31
Lines 816 872 +56
============================================
+ Hits 731 782 +51
- Misses 85 90 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
brettmc
requested changes
Oct 30, 2022
mmanciop
force-pushed
the
ecs-detector-revamp
branch
from
6ee70ac
to
94c7d9a
Compare
brettmc
approved these changes
Oct 31, 2022
|
@brettmc what needs to happen before we can merge this? |
|
@mmanciop - merging now! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the look-alike of others like open-telemetry/opentelemetry-js-contrib#1083, open-telemetry/opentelemetry-python-contrib#1212 and open-telemetry/opentelemetry-go-contrib#2626.