-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(auto-instrumentations-node): disabling instrumentations via env var #2174
base: main
Are you sure you want to change the base?
feat(auto-instrumentations-node): disabling instrumentations via env var #2174
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2174 +/- ##
==========================================
- Coverage 90.97% 90.40% -0.57%
==========================================
Files 146 149 +3
Lines 7492 7527 +35
Branches 1502 1577 +75
==========================================
- Hits 6816 6805 -11
- Misses 676 722 +46
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that adding this env var was already commented in the linked PR here. I guess you already have the use case for this :)
I do keep getting the request for the simplest possible setup, and iterating from there. So this is similar to how many folks have gotten started with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I strongly support this feature, which I find more usable than the enabled
list option.
The code changes looks good to me.
Thank you for working on this and adding this option
@open-telemetry/javascript-approvers Just wanted to ping to see if anyone else wanted a review before merging, since this is the auto-instr package so it is a bit more far-reaching than a single instrumentation. Otherwise will merge on Monday! |
Which problem is this PR solving?
Short description of the changes
OTEL_NODE_DISABLED_INSTRUMENTATIONS
environment variable. This is similar to the use case when instrumenting in code usinggetNodeAutoInstrumentations()
where someone may want to start with every instrumentation and pare down from there.