feat(instrumentation-koa): identify middleware functions inside route handlers #2037
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Considering the following route handler:
...will generate two spans with the same name:
router - /post/:id
, even though the first handler is actually a named middleware (some
).Ideally, it would generate two different spans:
middleware - some
router - /post/:id
Short description of the changes
The changes are quite simple: when iterating these handlers, we assume they are a middleware if it's not the last handler on the stack and if it has a name.